Carcassonne Central

Carc Central Community => Online Games and Competitions => JCloisterZone FAQ, Suggestions & Bug Reports => Topic started by: rfielder on November 13, 2018, 08:26:30 AM

Title: JCZ 4.3.0 Issues
Post by: rfielder on November 13, 2018, 08:26:30 AM
Am I the only one having a problem with 4.3.0?

One three different PCs, both local games and online games.

After the computer makes a move, a red banner appears saying something about an illegal tile placement.  After that, the game is done.  Clicking the X on the red banner sometimes makes it go away, sometimes not.

In every case, the computer has made its move, but everything just stops.  My only option is to kill the game.

I am running Windows 10 with the latest Java.  Java has been updated once or twice since this issue began.
Title: Re: JCZ 4.3.0 Issues
Post by: TheSteveAllen on November 13, 2018, 08:53:25 AM
You are not the only one. This problem has been reported to Farin. It does the same on Mac and Ubuntu, not just windows.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on November 13, 2018, 09:06:26 AM
You are not the only one. This problem has been reported to Farin. It does the same on Mac and Ubuntu, not just windows.
Yes there is no mention of the issue here?

How can anyone consider entering a competition when there is a high likelyhood that the application will crash??
Title: Re: JCZ 4.3.0 Issues
Post by: Decar on November 13, 2018, 10:46:34 AM
is the computer playing in the competition?

Can someone share the full stack trace of the error. I'll take a look at it.

Also don't forget CBB is still broken.
Title: Re: JCZ 4.3.0 Issues
Post by: danisthirty on November 13, 2018, 12:47:36 PM
How can anyone consider entering a competition when there is a high likelyhood that the application will crash??

Welcome back Robert, it's good to hear from you again! :(y)

You should know as well as anyone else that playing via the online server is not the only option, having made your own online server available for others during previous competitions! Even if there isn't sufficient time to address this issue before the start of the competition, there are plenty of others who can and will host games if necessary.

So now you don't have any excuses for not signing up... ;)
Title: Re: JCZ 4.3.0 Issues
Post by: TheSteveAllen on November 13, 2018, 02:43:21 PM
It would appear to be an issue with an updated server. I am trying it out tomorrow evening to see if the proposed server reboot tonight has made a difference.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on November 14, 2018, 06:15:12 AM
Also don't forget CBB is still broken.
What is CBB?
Title: Re: JCZ 4.3.0 Issues
Post by: danisthirty on November 14, 2018, 06:17:07 AM
Also don't forget CBB is still broken.
What is CBB?

Castles, Bridges & Bazaars. There is bug to do with the bazaars in particular whereby auctioned tiles aren't removed from the deck properly with the result being that they may be drawn twice!
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on November 14, 2018, 06:26:19 AM
Can someone share the full stack trace of the error. I'll take a look at it.
I have no idea how to get a "full stack trace".

Attached are the error.log file, and a screen capture of the error presented on the screen.  Had to rename the error.log file, since the forum software would not allow a .log file to be uploaded.

The problem is that it is now the computer's turn to play, and the computer never makes a move.  Everything else is fully functional.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on November 22, 2018, 06:30:24 PM

Wow - this discussion sure came to a dead stop!

Did I offend someone?
Title: Re: JCZ 4.3.0 Issues
Post by: danisthirty on November 23, 2018, 05:49:24 AM
Wow - this discussion sure came to a dead stop!

Did I offend someone?

I expect so. Welcome to the club!

I'm not sure whether this is going either. Personally I haven't encountered the same problem you describe here and many of us have been using the current version of JCZ between ourselves and via the server with a good degree of success. So drawing blanks here too I'm afraid.
Title: Re: JCZ 4.3.0 Issues
Post by: TheSteveAllen on November 23, 2018, 06:22:33 AM
Wow - this discussion sure came to a dead stop!

Did I offend someone?

I expect so. Welcome to the club!

I'm not sure whether this is going either. Personally I haven't encountered the same problem you describe here and many of us have been using the current version of JCZ between ourselves and via the server with a good degree of success. So drawing blanks here too I'm afraid.

I know that farin has been trying out a few things on his server and I have tested it out for him twice recently. I failed to break it on both occasions.

This does not mean that it is fixed, however, as we need more people to test it out and report back to us (by us, I mean Farin).

As far as I know, for the moment, it is fixed, until someone tells me otherwise.
Title: Re: JCZ 4.3.0 Issues
Post by: Decar on November 23, 2018, 08:58:27 AM
Oh sorry!

Whenever Java breaks it produces a stacktrace, which is basically a means of it telling us what it was doing (and how it got there) when it broke.
That can give us a clue what it was trying to do before it failed.

Usually, the errors and absorbed at runtime (so not to scare you), but if you run JCZ on the command line or on the console, it usually prints the errors out there.

If you open your JCZ folder on the command line and execute:

java -jar jcloisterzone.XXXX.jar

When you break it, I'd expect to see something on your console/command line.

If you're not comfortable running stuff on the command line, it can be a little harder to find.

As an alternative, If you're lucky you may have an error.log file in your JCZ folder!
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on December 08, 2018, 07:01:48 AM
Whenever Java breaks it produces a stacktrace, which is basically a means of it telling us what it was doing (and how it got there) when it broke.
That can give us a clue what it was trying to do before it failed.
Sorry, have not been here for a bit.

I will run JCZ and see about getting the data dump.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on December 12, 2018, 05:02:28 PM
One dump as requested:

C:\JCloisterZone>java -jar jcloisterzone.jar
[Thread-8] ERROR com.jcloisterzone.ui.view.GameView - java.lang.IllegalArgumentException: Invalid placement [4,1],R270
java.lang.RuntimeException: java.lang.IllegalArgumentException: Invalid placement [4,1],R270
        at com.jcloisterzone.game.GameStatePhaseReducer.applyMessageOnPhase(GameStatePhaseReducer.java:147)
        at com.jcloisterzone.game.GameStatePhaseReducer.apply(GameStatePhaseReducer.java:168)
        at com.jcloisterzone.game.Game.handleInGameMessage(Game.java:266)
        at sun.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at com.jcloisterzone.wsio.MessageDispatcher.dispatchOn(MessageDispatcher.java:38)
        at com.jcloisterzone.wsio.MessageDispatcher.dispatch(MessageDispatcher.java:21)
        at com.jcloisterzone.ui.ClientMessageListener.onWebsocketMessage(ClientMessageListener.java:137)
        at com.jcloisterzone.wsio.WebSocketConnection$WebSocketClientImpl.onMessage(WebSocketConnection.java:106)
        at org.java_websocket.client.WebSocketClient.onWebsocketMessage(WebSocketClient.java:248)
        at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:375)
        at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:158)
        at org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:185)
        at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.IllegalArgumentException: Invalid placement [4,1],R270
        at com.jcloisterzone.game.phase.TilePhase.lambda$handlePlaceTile$3(TilePhase.java:163)
        at io.vavr.control.Option.getOrElseThrow(Option.java:332)
        at com.jcloisterzone.game.phase.TilePhase.handlePlaceTile(TilePhase.java:163)
        at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at com.jcloisterzone.game.GameStatePhaseReducer.applyMessageOnPhase(GameStatePhaseReducer.java:145)
        ... 14 more
Title: Re: JCZ 4.3.0 Issues
Post by: Decar on December 13, 2018, 03:59:42 AM
Hmm, I think I've seen this before.

The AI has managed to place a tile in an invalid position. I think it's to do with how quickly the tiles are placed.

Thanks for grabbing the trace - if I get time I'll have a go at reproducing.
It's a bit annoying the game state isn't available here.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on January 04, 2019, 09:27:46 AM
One more bit to the puzzle.

The crash only occurs when using the dragon, and it always occurs when the computer is moving the dragon and has the last move of the dragon and the next tile placement.

In other words, I start the dragon, the computer has the last dragon move.  When the last move is taken, the error occurs, and the computer never places a tile.
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on February 20, 2019, 09:27:18 AM
It would seem that crashes occur at different rates with different expansions active.

Given the absence of discussion and general lack of updates, I assume development of the game has ended?
Title: Re: JCZ 4.3.0 Issues
Post by: danisthirty on February 20, 2019, 10:08:39 AM
I'm not sure what farin's priorities are at the moment but I don't think JCloisterZone features among them.

I don't share the difficulties you've been experiencing with JCZ so it's difficult to comment on them as I can't replicate them.
Title: Re: JCZ 4.3.0 Issues
Post by: totor66 on March 01, 2019, 12:20:16 AM
I was also having constantly a bug VS computer when playing with crop circles.

It occured when we were offering players choice to add meeple, and computer didn't have, it was crashing

Title: Re: JCZ 4.3.0 Issues
Post by: farin on April 08, 2019, 12:41:22 PM
Hi guys

it's complicated with priorities now. Second child, involved in startup project ...
On the other hand, issues with computer player is annoying.

As far as know almost all bug reports I received by email was this kind. So I would be nice fix this.




Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on April 09, 2019, 06:56:46 PM
Downloaded and installed 4.3.1 on two computers.

On both, it will not start a new game, and the Online play just sits there "Connecting" and nothing ever happens.
Title: Re: JCZ 4.3.0 Issues
Post by: danisthirty on April 09, 2019, 11:37:19 PM
Hi guys

it's complicated with priorities now. Second child, involved in startup project ...

Congratulations on the new arrival farin! And thanks for your continued efforts with JCZ despite all your new time commitments!

Downloaded and installed 4.3.1 on two computers.

On both, it will not start a new game, and the Online play just sits there "Connecting" and nothing ever happens.

Strange. It works fine in every respect on my computer... ?
Title: Re: JCZ 4.3.0 Issues
Post by: farin on April 10, 2019, 01:10:06 AM
firewall? port settings? No change was made about connection or server code.

Downloaded and installed 4.3.1 on two computers.

On both, it will not start a new game, and the Online play just sits there "Connecting" and nothing ever happens.
Title: Re: JCZ 4.3.0 Issues
Post by: farin on April 11, 2019, 12:40:06 AM
rfielder: what Java version you are using? It seems there is change in java std lib API causing troubles when source is compiled with recent java but run with Java 8.
I get reports with error java.lang.NoSuchMethodError: java.nio.ByteBuffer.limit(I)Ljava/nio/ByteBuffer, and found same issue reported eg there https://github.com/apache/felix/pull/114
Title: Re: JCZ 4.3.0 Issues
Post by: farin on April 11, 2019, 01:48:31 AM
Could you try version patched for Java 8? I don't have Java 8 here.

I have confirmation, that repacked version works with Java 8. Try it. (For newer runtime you can stay with 4.3.1)

http://play.jcloisterzone.com/builds/JCloisterZone-4.3.2.7z
or
http://play.jcloisterzone.com/builds/JCloisterZone-4.3.2.tgz
Title: Re: JCZ 4.3.0 Issues
Post by: rfielder on April 11, 2019, 03:43:23 AM
Farin - 4.3.2 starts OK.  Thanks!

Have not played a game yet, just verified that it will start a game, and will connect for an online game.